Skip to content

chore(api): bump uuid to 11 and drop @types/uuid - #3676

Open
teeohhem wants to merge 1 commit into
mainfrom
claude/api-uuid-11
Open

teeohhem wants to merge 1 commit into
mainfrom
claude/api-uuid-11

Conversation

@teeohhem

Copy link
Copy Markdown
Contributor

Summary

Bump uuid in packages/api from 8.3.2 to 11.1.1 and drop @types/uuid.

  • uuid 8.3.2 is flagged by GHSA-w5hq-g745-h8pq, fixed in 11.1.1.
  • uuid 11 ships its own TypeScript types, so @types/uuid is no longer needed.
  • The api only uses v4 (import { v4 as uuidv4 } from 'uuid'), whose import and behavior are unchanged. uuid 11 still provides a CommonJS build, so require and ts-jest keep working.

How to test locally or on Vercel

  1. yarn install
  2. cd packages/api && npx tsc --noEmit: passes.
  3. yarn ci:unit: 80 suites, 1525 tests pass.

I did not run the integration tests. The code paths that generate IDs (team and user creation, the access-key migration) call the same v4 function.

🤖 Generated with Claude Code

uuid 8.3.2 is flagged by GHSA-w5hq-g745-h8pq, fixed in 11.1.1. uuid 11 ships
its own TypeScript types, so @types/uuid is no longer needed. The api only
uses `v4`, whose import and behavior are unchanged.
@teeohhem
teeohhem requested a review from a team as a code owner November 16, 2026 15:45
@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperdx-oss Ready Ready Preview Nov 16, 2026 3:50pm UTC
hyperdx-storybook Ready Ready Preview Nov 16, 2026 3:50pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 31e7ce2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/api Patch
@hyperdx/app Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

PR Review

✅ No issues found.

@github-actions

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 1
  • Production lines changed: 3
  • Branch: claude/api-uuid-11
  • Author: teeohhem

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

Copy link
Copy Markdown
Contributor

Duplicate code analysis

No new duplicate code introduced by this PR.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 108 in total (1.18%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@github-actions

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

This is a tightly scoped, low-risk dependency bump: uuid ^8.3.2 → ^11.1.1 in packages/api, with @types/uuid dropped. All usage is the version-stable named import import { v4 as uuidv4 } from 'uuid', Node engine >=22.16.0 clears uuid 11's floor, and jest/ts-jest resolves uuid 11's CJS build via its exports map, so the test path is unaffected. The changeset is well-formed and the package name/bump type are correct.

🔵 P3 nitpicks (1)
  • yarn.lock:30729 — uuid@8.3.2 still resolves transitively via @aws-sdk/middleware-retry@3.272.0, so the old major is not fully removed from the dependency tree; this copy is pre-existing and not introduced by this diff, and uuid's v4 generator is crypto-backed with no verified exploit.
    • Fix: Accept as out-of-scope since the direct bump achieves the PR's stated goal; if full tree removal is later required, add a resolutions override or bump the @aws-sdk/* chain in a follow-up.
    • security

Reviewers (4): correctness, project-standards, kieran-typescript, security.

Testing gaps:

  • No unit test exercises the uuidv4() import sites (controllers/user.ts, controllers/team.ts, models/user.ts, models/team.ts, and migrations/mongo/20231130053610-add_accessKey_field_to_user_collection.ts), so uuid 11 CJS resolution under the ts-jest preset is verified by analysis rather than an actual run; yarn install && tsc --noEmit plus yarn ci:unit locally would confirm empirically.
  • Prior PR comments were automated bot notices only (Vercel, changeset-bot); no human review feedback required verification.

No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond

@github-actions

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 467 passed • 1 skipped • 1172s

Status Count
✅ Passed 467
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

This branch was successfully deployed

2 active deployments
Preview – hyperdx-oss — 31e7ce2b Deployed Nov 16, 2026 by vercel[bot]
Preview – hyperdx-storybook — 31e7ce2b Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant